From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 4/6] transport: add refspec list parameters to functions
Date: Tue, 19 Apr 2016 15:31:03 -0400 [thread overview]
Message-ID: <1461094263.5540.113.camel@twopensource.com> (raw)
In-Reply-To: <xmqqa8kq69i5.fsf@gitster.mtv.corp.google.com>
On Mon, 2016-04-18 at 11:45 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
>
> > Add parameters for a list of refspecs to transport_get_remote_refs
> > and
> > get_refs_list. These parameters are presently unused -- soon, we
> > will
> > use them to implement fetches which only learn about a subset of
> > refs.
> >
> > Signed-off-by: David Turner <dturner@twopensource.com>
> > ---
>
> What the code tries to do I am more than halfway happy. It is
> unfortunate that we cannot do this natively without upgrading the
> protocol in a fundamental way, but this is a nice way to work it
> around only for Git-over-HTTP transport without having to break the
> protocol.
>
> As a POC it is OK, but I am moderately unhappy with the use of
> "refspec" here.
>
> At the transport layer, we shouldn't care what the receiving end
> intends to do with the objects that sits at the tip of the refs at
> the other end, so sending "refspecs" down feels somewhat wrong for
> this feature. At one layer up in the next patch, you do use
> "interesting refs" which makes it clear that only the left-hand-side
> of a refspec, i.e. what they call it, matters, and I think that is a
> much better phrasing of the concept (and the passed data should only
> be the left-hand-side of refspecs).
I will rename the parameter to "interesting_refs".
next prev parent reply other threads:[~2016-04-19 19:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 19:19 [PATCH/RFC 0/6] fetch with refspec David Turner
2016-04-15 19:19 ` [PATCH/RFC 1/6] http-backend: use argv_array functions David Turner
2016-04-18 18:34 ` Junio C Hamano
2016-04-19 19:11 ` David Turner
2016-04-15 19:19 ` [PATCH/RFC 2/6] remote-curl.c: fix variable shadowing David Turner
2016-04-18 18:35 ` Junio C Hamano
2016-04-19 19:14 ` David Turner
2016-04-15 19:19 ` [PATCH/RFC 3/6] http-backend: handle refspec argument David Turner
2016-04-17 1:51 ` Eric Sunshine
2016-04-19 18:57 ` David Turner
2016-04-15 19:19 ` [PATCH/RFC 4/6] transport: add refspec list parameters to functions David Turner
2016-04-18 18:45 ` Junio C Hamano
2016-04-19 7:14 ` Jeff King
2016-04-19 18:04 ` Stefan Beller
2016-04-19 20:55 ` Junio C Hamano
2016-04-19 21:40 ` David Turner
2016-04-19 23:22 ` Jeff King
2016-04-19 23:43 ` David Turner
2016-04-20 1:17 ` Jeff King
2016-04-20 20:46 ` David Turner
2016-04-20 20:57 ` Jeff King
2016-04-25 16:44 ` David Turner
2016-04-25 22:10 ` Stefan Beller
2016-04-27 3:59 ` Stefan Beller
2016-04-27 4:11 ` Jeff King
2016-04-27 15:07 ` Junio C Hamano
2016-04-29 23:05 ` David Turner
2016-04-29 23:12 ` Stefan Beller
2016-04-19 19:31 ` David Turner [this message]
2016-04-15 19:19 ` [PATCH/RFC 5/6] fetch: pass refspec to http server David Turner
2016-04-17 2:33 ` Eric Sunshine
2016-04-19 21:25 ` David Turner
2016-04-15 19:19 ` [PATCH/RFC 6/6] clone: send refspec for single-branch clones David Turner
2016-04-17 2:36 ` Eric Sunshine
2016-04-19 21:24 ` David Turner
2016-04-15 19:30 ` [PATCH/RFC 0/6] fetch with refspec Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461094263.5540.113.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).