git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v7 p1 13/13] fast-export: fix comparison in tests
Date: Wed, 28 Nov 2012 23:11:09 +0100	[thread overview]
Message-ID: <1354140669-23533-14-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1354140669-23533-1-git-send-email-felipe.contreras@gmail.com>

First the expected, then the actual, otherwise the diff would be the
opposite of what we want.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9350-fast-export.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
index 5948b65..1f59862 100755
--- a/t/t9350-fast-export.sh
+++ b/t/t9350-fast-export.sh
@@ -303,7 +303,7 @@ test_expect_success 'dropping tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=drop mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -320,7 +320,7 @@ test_expect_success 'rewriting tag of filtered out object' '
 (
 	cd limit-by-paths &&
 	git fast-export --tag-of-filtered-object=rewrite mytag -- there > output &&
-	test_cmp output expected
+	test_cmp expected output
 )
 '
 
@@ -351,7 +351,7 @@ test_expect_failure 'no exact-ref revisions included' '
 	(
 		cd limit-by-paths &&
 		git fast-export master~2..master~1 > output &&
-		test_cmp output expected
+		test_cmp expected output
 	)
 '
 
-- 
1.8.0.1

      parent reply	other threads:[~2012-11-28 22:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 22:10 [PATCH v7 p1 00/13] fast-export and remote-testgit improvements Felipe Contreras
2012-11-28 22:10 ` [PATCH v7 p1 01/13] fast-export: avoid importing blob marks Felipe Contreras
2012-11-28 22:10 ` [PATCH v7 p1 02/13] remote-testgit: fix direction of marks Felipe Contreras
2012-11-28 22:10 ` [PATCH v7 p1 03/13] remote-helpers: fix failure message Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 04/13] Rename git-remote-testgit to git-remote-testpy Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 05/13] Add new simplified git-remote-testgit Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 06/13] remote-testgit: remove non-local functionality Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 07/13] remote-testgit: remove irrelevant test Felipe Contreras
2012-12-03 23:13   ` Pete Wyckoff
2012-12-04 14:03     ` Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 08/13] remote-testgit: cleanup tests Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 09/13] remote-testgit: exercise more features Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 10/13] remote-testgit: report success after an import Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 11/13] remote-testgit: implement the "done" feature manually Felipe Contreras
2012-11-28 22:11 ` [PATCH v7 p1 12/13] fast-export: trivial cleanup Felipe Contreras
2012-11-28 22:11 ` Felipe Contreras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354140669-23533-14-git-send-email-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).