git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	Max Coplan via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, strager <strager.nds@gmail.com>,
	me <mchcopl@gmail.com>
Subject: Re: [PATCH v2] log: add option to search for header or body
Date: Sun, 7 Apr 2024 15:00:27 +0100	[thread overview]
Message-ID: <0bad6e79-42c6-4149-92f0-58c4726080b1@gmail.com> (raw)
In-Reply-To: <xmqq4jcdhfht.fsf@gitster.g>

On 07/04/2024 07:08, Junio C Hamano wrote:
> "Max Coplan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> I am imagining a pair of new options to name people (all OR'ed) and
> to name places the names of these people should appear (again, all
> OR'ed).  I am not good at naming, so the option names in the example
> is not more than illustration of an idea and not my recommendation,
> but a command:
> 
>      git log --by="Max Coplan" --by="Junio C Hamano" \
> 	    --by-where=author,Signed-off-by,Co-authored-by
> 
> would find a commit that has one (or more) of the given names
> in one (or more) of the places that are specified, where the places
> can be either "author", "committer" to specify these headers in the
> commit object, or random other string to specify trailer lines with
> given keys.

I like this, yesterday[1] I didn't have a clear idea in my head of how 
such an option should work but I think passing the names and the fields 
to match those names against as two separate options is a good idea.

Best Wishes

Phillip

[1] 
https://lore.kernel.org/git/c93817ba-5945-4ec0-9775-5621481b972c@gmail.com/


      reply	other threads:[~2024-04-07 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 21:48 [PATCH] feat(log): add option to search for header or body to `git log` Max Coplan via GitGitGadget
2024-04-06 14:04 ` Phillip Wood
2024-04-07  3:24 ` [PATCH v2] log: add option to search for header or body Max Coplan via GitGitGadget
2024-04-07  6:08   ` Junio C Hamano
2024-04-07 14:00     ` Phillip Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bad6e79-42c6-4149-92f0-58c4726080b1@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=mchcopl@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=strager.nds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).