git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Philip Oakley <philipoakley@iee.org>
To: Junio C Hamano <gitster@pobox.com>, Philip Oakley <philipoakley@iee.org>
Cc: GitList <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>,
	Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Subject: Re: [RFC/PATCH v2] doc branch: provide examples for listing remote tracking branches
Date: Fri, 14 Jun 2019 22:00:52 +0100
Message-ID: <024373d9-e032-1af8-ba26-439ad5620bf5@iee.org> (raw)
In-Reply-To: <xmqqtvcxmig3.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On 10/06/2019 18:57, Junio C Hamano wrote:
> Philip Oakley <philipoakley@iee.org> writes:
>
>> The availability of these pattern selections is not obvious from
>> the man pages, as per mail thread <87lfz3vcbt.fsf@evledraar.gmail.com>.
>>
>> Provide examples.
>>
>> Re-order the `git branch` synopsis to emphasise the `--list <pattern>`
>> pairing. Also expand and reposition the `all/remotes` options.
>>
>> Split the over-long description into three parts so that the <pattern>
>> description can be seen.
>>
>> Clarify that the `all/remotes` options require the --list if patterns
>> are to be used.
>>
>> Add examples of listing remote tracking branches that match a pattern,
>> including `git for-each-ref` which has more options.
>>
>> Improve the -a/-r warning message. The message confused this author
>> as the combined -a and -r options had not been given, though a pattern
>> had. Specifically guide the user that maybe they needed the --list
>> option to enable a remote branch pattern selection.
>>
>> Signed-off-by: Philip Oakley <philipoakley@iee.org>
>> ---
>>
>> in response to
>> <2ea35ad4-4b33-0ece-4de4-b2e92a100d9a@iee.org>
>> thread: https://public-inbox.org/git/?q=%3CCACsJy8CwY8gzeWa9kNRX3ecez1JGiQiaOknbAoU7S%2BhiXBoUGQ%40mail.gmail.com%3E
>>
>> to: Git Mailing List <git@vger.kernel.org>
>> cc: Duy Nguyen <pclouds@gmail.com>
>> cc: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> cc: Junio C Hamano <gitster@pobox.com>
> This looks reasonable to me---is it ready to go even with its RFC prefix?

Yes; the RFC was only in regard of the die() message change as it 
touches real code;-)


Following the post, Stolee's coverage report, it was noted that the 
die() wasn't actually tested, so I sent a quick follow-up of a potential 
test 
https://public-inbox.org/git/f28dd5b1-fda8-cf51-5582-067a7d2c2472@iee.org/ 
which is a proper RFC...


I did not attempt to see if any other dies()'s were untested, just 
copied one that was..

Philip

(currently travelling)


  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18 15:16 Command to list <pattern> Branches on a specific Remote (i.e. select from rtb's) Philip Oakley
2019-05-18 18:37 ` Ævar Arnfjörð Bjarmason
2019-05-18 19:44   ` Philip Oakley
2019-05-19  3:07     ` Duy Nguyen
2019-05-19  9:49       ` Philip Oakley
2019-05-28 12:13       ` [PATCH] doc branch: provide examples for listing remote tracking branches Philip Oakley
2019-05-28 13:58         ` Junio C Hamano
2019-05-28 14:17           ` Philip Oakley
2019-05-28 14:51             ` Philip Oakley
2019-05-28 15:51               ` Junio C Hamano
2019-05-28 16:17                 ` Philip Oakley
2019-05-28 23:16                   ` [RFC/PATCH v2] " Philip Oakley
2019-06-10 17:57                     ` Junio C Hamano
2019-06-14 21:00                       ` Philip Oakley [this message]
2019-05-19  3:05   ` Command to list <pattern> Branches on a specific Remote (i.e. select from rtb's) Duy Nguyen
2019-05-28 13:57   ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=024373d9-e032-1af8-ba26-439ad5620bf5@iee.org \
    --to=philipoakley@iee.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror http://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox